Re: [PATCH] mkimage: powerpc: fix CHRP note descsz

[Daniel Kiper]

On Tue, Apr 07, 2020 at 04:17:26PM +1000, Daniel Axtens wrote:
> Currently, an image generated with 'grub-mkimage -n' causes an error when
> read with 'readelf -a':
>
> Displaying notes found at file offset 0x000106f0 with length 0x0000002c:
>   Owner                Data size        Description
> readelf: Warning: note with invalid namesz and/or descsz found at offset 0x0
> readelf: Warning:  type: 0x1275, namesize: 0x00000008, descsize: 0x0000002c, 
> alignment: 4
>
> This is because the descsz of the CHRP note is set to
>  sizeof (struct grub_ieee1275_note)
> which is the size of the entire note, including name and elf header. The
> desczs should contain only the contents, not the name and header sizes.
>
> Set the descsz instead to 'sizeof (struct grub_ieee1275_note_desc)'
>
> Resultant readelf output:
>
> Displaying notes found at file offset 0x00010710 with length 0x0000002c:
>   Owner                Data size        Description
>   PowerPC              0x00000018       Unknown note type: (0x00001275)
>    description data: ff ff ff ff 00 c0 00 00 ff ff ff ff ff ff ff ff ff ff ff 
> ff 00 00 40 00
>
> So far as I can tell this issue has existed for as long as the note
> generation code has existed, but I guess nothing really checks descsz.
>
> Signed-off-by: Daniel Axtens <address@hidden>

Reviewed-by: Daniel Kiper <address@hidden>

Daniel