Re: [PATCH] tftp: roll-over block counter to prevent data packets timeouts

[Alexey Makhalov]

> On Sep 9, 2020, at 4:12 AM, Daniel Kiper <daniel.kiper@oracle.com> wrote:
> 
> Hey Javier,
> 
> On Wed, Sep 09, 2020 at 12:47:20PM +0200, Javier Martinez Canillas wrote:
>> Hello Daniel,
>> 
>> Thanks for the review.
>> 
>> On 9/7/20 9:36 PM, Daniel Kiper wrote:
>>> On Tue, Sep 01, 2020 at 02:30:35PM +0200, Javier Martinez Canillas wrote:
>>>> Commit 781b3e5efc3 ("tftp: Do not use priority queue") caused a regression
>>> 
>>> Please drop the quotes.
>>> 
>> 
>> Sure, I can do that but I wonder why you don't want the quotes.
>> That's the convention used in many other projects.
> 
> I think quotes are superfluous if you have parentheses.
> 
>> [snip]
>> 
>>>> 
>>>> Fixes: 781b3e5efc3 ("tftp: Do not use priority queue")
>>> 
>>> Please drop this line.
>>> 
>> 
>> Same question here. I think is important information, specially for
>> downstream since they could allow people to decide whether they need
>> to backport this patch or not.
> 
> You duplicate the information which is above. Additionally, IMO "Fixes:"
> should contain bug number, CVE number, link to the bug, etc. not the
> commit id.

I think “Fixes: commit id” should remain in place. It provides direct 
information
from what commit the bug existed in case of regression.

—Alexey

signature.asc
Description: Message signed with OpenPGP