[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 05/12] luks2: grub_cryptodisk_t->total_sectors is the max
From: |
Glenn Washburn |
Subject: |
Re: [PATCH v6 05/12] luks2: grub_cryptodisk_t->total_sectors is the max number of device native sectors |
Date: |
Thu, 3 Dec 2020 02:54:19 -0600 |
On Wed, 2 Dec 2020 18:56:46 +0100
Daniel Kiper <dkiper@net-space.pl> wrote:
> On Fri, Nov 27, 2020 at 03:03:37AM -0600, Glenn Washburn wrote:
> > We need to convert the sectors from the size of the underlying
> > device to the cryptodisk sector size; segment.size is in bytes
> > which need to be converted to cryptodisk sectors as well. And
> > counter-intuitively, grub_disk_get_size returns the total number of
> > device native sectors.
>
> Should not we change the name to, e.g., grub_disk_native_sectors()
> then? Could you do that?
Sure, I can do that.
> > Also, removed an empty statement.
> >
> > Signed-off-by: Glenn Washburn <development@efficientek.com>
>
> Otherwise Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
>
> Daniel