Re: [PATCH v6 02/12] luks2: Use more intuitive slot key instead of index in user messages.

[Daniel Kiper]

On Thu, Dec 03, 2020 at 01:24:18AM -0600, Glenn Washburn wrote:
> On Wed, 2 Dec 2020 18:23:08 +0100
> Daniel Kiper <dkiper@net-space.pl> wrote:
>
> > On Fri, Nov 27, 2020 at 03:03:34AM -0600, Glenn Washburn wrote:
> > > Use the slot key name in the json array rather than the 0 based
> > > index in the json array for keyslots, segments, and digests. This
> > > is less confusing for the end user. For example, say you have a
> > > LUKS2 device with a key in slot 1 and slot 4. When using the
> > > password for slot 4 to unlock the device, the messages using the
> > > index of the keyslot will mention keyslot 1 (its a zero-based
> > > index). Furthermore, with this change the keyslot number will align
> > > with the number used to reference the keyslot when using the
> > > --key-slot argument to cryptsetup. Error messages now distinguish
> > > between indexes and slot keys. The former include the string
> > > "index" in the error string, and the later are surrounded in quotes.
> >
> > This should be split into two separate patches. One should add "index"
> > to the messages another should add quotes. Well, I am not convinced
> > that quotes are good differentiators... I would drop them or rephrase
> > messages to really differentiate indexes and slot keys.
>
> I thought the quotes would make more intuitive sense to a user because
> the value would also be quoted in the json which would be output when
> using cryptosetup with --debug-json.  I can split it in to two patches,
> but just tell me how you want me to rephrase and I will.  No need for
> another round of reviews.

OK, let's stick with the quotes then.

Daniel