Re: [PATCH 2.06 RELEASE 2/3] i18n: Align N_() formatting with the rest of GRUB code

[Daniel Kiper]

On Fri, Apr 23, 2021 at 05:49:49PM +0200, Javier Martinez Canillas wrote:
> On 4/14/21 5:48 PM, Daniel Kiper wrote:
> > Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
> > ---
> >  grub-core/commands/ls.c       |  2 +-
> >  grub-core/commands/terminal.c | 10 +++++-----
> >  2 files changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/grub-core/commands/ls.c b/grub-core/commands/ls.c
> > index 326d2d6b4..8e98c73cc 100644
> > --- a/grub-core/commands/ls.c
> > +++ b/grub-core/commands/ls.c
> > @@ -70,7 +70,7 @@ grub_ls_list_devices (int longlist)
> >      FOR_NET_APP_LEVEL (proto)
> >      {
> >        if (first)
> > -   grub_puts_ (N_ ("Network protocols:"));
> > +   grub_puts_ (N_("Network protocols:"));
>
> Is part of the coding style that functions calls should have a space between
> the function name and the parenthesis but not when using macros ? I haven't
> found anything about it in the docs/grub-dev.texi file.

As I can see from the code the translation macros are exception from
the "extra space" rule.

> But it's true that this change makes it consistent with the rest of the GRUB
> codebase, so the patch looks good to me.
>
> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

Thanks a lot!

Daniel