Re: [PATCH v2 1/2] MAINTAINERS: Add MAINTAINERS file

[Paul Menzel]

Dear Daniel,


Am 07.06.21 um 20:07 schrieb Daniel Kiper:
> The MAINTAINERS file provides basic information about the GRUB project
> and its maintainers.
>
> Signed-off-by: Alex Burmashev <alexander.burmashev@oracle.com>
> Signed-off-by: Vladimir Serbinenko <phcoder@google.com>
> Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
> ---
> v2 - suggestions/fixes:
>     - mention the MAINTAINERS file in the README file
>       (suggested by Paul Menzel),
>     - s/http/https/
>       (suggested by Paul Menzel).
> ---
>   MAINTAINERS | 31 +++++++++++++++++++++++++++++++
>   README      |  2 ++
>   2 files changed, 33 insertions(+)
>   create mode 100644 MAINTAINERS
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> new file mode 100644
> index 000000000..9eff2b8ab
> --- /dev/null
> +++ b/MAINTAINERS
> @@ -0,0 +1,31 @@
> +List of current GRUB maintainers and some basic information about the project
> +=============================================================================
> +
> +Here is the list of current GRUB maintainers:
> +  - Daniel Kiper <daniel.kiper@oracle.com> and <dkiper@net-space.pl>,
> +  - Alex Burmashev <alexander.burmashev@oracle.com>,
> +  - Vladimir 'phcoder' Serbinenko <phcoder@gmail.com>.
> +
> +The maintainers drive and overlook the GRUB development.
> +
> +The GRUB development happens on the grub-devel mailing list [1]. The latest
> +GRUB source code is available at Savannah git repository [2].
> +
> +Users can ask for help on the help-grub mailing list [3].
> +
> +
> +List of past GRUB maintainers and people who strongly contributed to the 
> project
> +================================================================================
> +
> +Here is the list, sorted alphabetically, of past GRUB maintainers and people 
> who
> +strongly contributed to the project:
> +  - Andrei Borzenkov,
> +  - Bryan Ford,
> +  - Erich Stefan Boleyn,
> +  - Gordon Matzigkeit,
> +  - Yoshinori K. Okuji.
> +
> +
> +[1] https://lists.gnu.org/mailman/listinfo/grub-devel
> +[2] https://git.savannah.gnu.org/gitweb/?p=grub.git&view=view+git+repository
> +[3] https://lists.gnu.org/mailman/listinfo/help-grub
> diff --git a/README b/README
> index 685b01657..b1aa79723 100644
> --- a/README
> +++ b/README
> @@ -7,6 +7,8 @@ See the file NEWS for a description of recent changes to GRUB 2.
>   See the file INSTALL for instructions on how to build and install the
>   GRUB 2 data and program files.
>   
> +See the file MAINTAINERS for information about the GRUB maintainers, etc.
> +

I still think, it’s a little confusing to have the information about the 
list and the source code URL in the file `MAINTAINERS`.

>   Please visit the official web page of GRUB 2, for more information.
>   The URL is <http://www.gnu.org/software/grub/grub.html>.
>   

Otherwise this looks good.


Kind regards,

Paul