Re: [PATCH 1/2] osdep: Introduce major.h and use it

[Petr Vorel]

Hi Daniel,

...
> > > +/*
> > > + * Fix for glibc 2.25 is deprecating the namespace pollution of 
> > > sys/types.h
> > > + * injecting major(), minor(), and makedev() into the compilation 
> > > environment.
> > > + * See configure.ac.

> > It seems to me "See configure.ac." is not relevant in the GRUB source.
> > So, probably it should be replaced with some text from glibc configure.ac.

> I didn't know how to link AC_HEADER_MAJOR with include/grub/osdep/major.h.
> Because in the future when glibc 2.25 is old enough the header will be removed
> and AC_HEADER_MAJOR might be left in configure.ac (name is different from
> MAJOR_IN_{MKDEV,SYSMACROS}). But I can note this in commit message instead.
But thinking about it twice also note in configure.ac instead (+ commit message)
would be good. But that's just a minor detail.

Kind regards,
Petr

> Kind regards,
> Petr

> > Daniel