[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests: Let xorriso fixely assume UTF-8 as local character se
|
From: |
Daniel Kiper |
|
Subject: |
Re: [PATCH] tests: Let xorriso fixely assume UTF-8 as local character set |
|
Date: |
Wed, 8 Sep 2021 21:06:54 +0200 |
|
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Tue, Sep 07, 2021 at 09:15:58PM +0000, Glenn Washburn wrote:
> On Wed, 1 Sep 2021 15:11:38 +0200
> Daniel Kiper <dkiper@net-space.pl> wrote:
>
> > On Fri, Aug 27, 2021 at 11:05:06PM +0200, Thomas Schmitt wrote:
> > > iso9660_test fails if the effective locale is not UTF-8. This
> > > happens because xorriso needs to convert file names and FSLABEL to
> > > UCS-2 when preparing a Joliet tree. grub-fs-tester obviously
> > > intends to use UTF-8 as character set, but xorriso assumes by
> > > default the result of nl_langinfo(3) with item CODESET.
> > > So override the result of nl_langinfo(CODESET) by options of
> > > xorriso -as mkisofs.
> > >
> > > Signed-off-by: Thomas Schmitt <scdbackup@gmx.net>
> >
> > Thomas, Glenn, thank you for doing such deep investigation!
> >
> > Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
> >
> > Glenn, did you test this patch?
>
> Coming to this late, had some issues which kept me away. I notice that
No worries...
> the patch is already in master, but for what its worth, I have now
> tested with the patch and LANG unset and the test now succeeds. Thanks
Thank you for doing test.
Daniel