Re: [PATCH 11/19] efi: mm: Extract function to add memory regions

[Daniel Kiper]

On Tue, Oct 12, 2021 at 06:30:00PM +1100, Daniel Axtens wrote:
> From: Patrick Steinhardt <ps@pks.im>
>
> In preparation of support for runtime-allocating additional memory
> region, this patch extracts the function to retrieve the EFI memory map
> and add a subset of it to GRUB's own memory regions.
>
> Signed-off-by: Patrick Steinhardt <ps@pks.im>
> ---
>  grub-core/kern/efi/mm.c | 23 ++++++++++++++++-------
>  1 file changed, 16 insertions(+), 7 deletions(-)
>
> diff --git a/grub-core/kern/efi/mm.c b/grub-core/kern/efi/mm.c
> index 4d276bc87a4c..cfc6a67fc0cc 100644
> --- a/grub-core/kern/efi/mm.c
> +++ b/grub-core/kern/efi/mm.c
> @@ -504,7 +504,7 @@ add_memory_regions (grub_efi_memory_descriptor_t 
> *memory_map,
>
>        addr = grub_efi_allocate_pages_real (start, pages,
>                                          GRUB_EFI_ALLOCATE_ADDRESS,
> -                                        GRUB_EFI_LOADER_CODE);
> +                                        GRUB_EFI_LOADER_CODE);

Please drop this change.

...and if possible please take into account Glenn's comments...

Daniel