[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] Fix vlan networking on little-endian systems
From: |
Daniel Kiper |
Subject: |
Re: [PATCH v2] Fix vlan networking on little-endian systems |
Date: |
Wed, 2 Mar 2022 21:57:34 +0100 |
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Wed, Mar 02, 2022 at 02:21:22PM -0500, Chad Kimes via Grub-devel wrote:
> Vlan configuration seems to have never worked on little-endian systems. This
> is
> likely because VLANTAG_IDENTIFIER is not byte-swapped before copying into the
> net buffer, nor is vlantag. We can resolve this by using grub_cpu_to_be16 and
> its inverse when copying vlan info to/from the net buffer.
>
> Signed-off-by: Chad Kimes <chkimes@github.com>
Thank you for fixing this.
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
Daniel