[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 4/5] cryptodisk: Use enum constants as indexes into crypto
From: |
Daniel Kiper |
Subject: |
Re: [PATCH v2 4/5] cryptodisk: Use enum constants as indexes into cryptomount option array |
Date: |
Thu, 19 May 2022 20:24:11 +0200 |
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Fri, May 13, 2022 at 12:00:50PM -0500, Glenn Washburn wrote:
> Signed-off-by: Glenn Washburn <development@efficientek.com>
> ---
> grub-core/disk/cryptodisk.c | 53 ++++++++++++++++++++++---------------
> 1 file changed, 32 insertions(+), 21 deletions(-)
>
> diff --git a/grub-core/disk/cryptodisk.c b/grub-core/disk/cryptodisk.c
> index 94640b502..ecbda7ce9 100644
> --- a/grub-core/disk/cryptodisk.c
> +++ b/grub-core/disk/cryptodisk.c
> @@ -35,6 +35,17 @@ GRUB_MOD_LICENSE ("GPLv3+");
>
> grub_cryptodisk_dev_t grub_cryptodisk_list;
>
> +enum
> + {
> + OPTION_UUID,
> + OPTION_ALL,
> + OPTION_BOOT,
> + OPTION_PASSWORD,
> + OPTION_KEYFILE,
> + OPTION_KEYFILE_OFFSET,
> + OPTION_KEYFILE_SIZE
> + };
I would prefer constants here.
Otherwise patches LGTM.
Daniel
- [PATCH v2 0/5] Cryptomount keyfile support, Glenn Washburn, 2022/05/13
- [PATCH v2 1/5] cryptodisk: luks: Unify grub_cryptodisk_dev function names, Glenn Washburn, 2022/05/13
- [PATCH v2 2/5] cryptodisk: geli: Unify grub_cryptodisk_dev function names, Glenn Washburn, 2022/05/13
- [PATCH v2 3/5] cryptodisk: Add options to cryptomount to support keyfiles, Glenn Washburn, 2022/05/13
- [PATCH v2 5/5] docs: Add documentation on keyfile option to cryptomount, Glenn Washburn, 2022/05/13
- [PATCH v2 4/5] cryptodisk: Use enum constants as indexes into cryptomount option array, Glenn Washburn, 2022/05/13
- Re: [PATCH v2 4/5] cryptodisk: Use enum constants as indexes into cryptomount option array,
Daniel Kiper <=