[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] efi: compile kernel.img with -fshort-wchar on all EFI target
From: |
Daniel Kiper |
Subject: |
Re: [PATCH] efi: compile kernel.img with -fshort-wchar on all EFI targets |
Date: |
Thu, 13 Oct 2022 19:20:07 +0200 |
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Tue, Oct 11, 2022 at 01:26:33PM +0100, Chris Coulson wrote:
> The stack check logs a console message on failure, and the EFI API expects
> a NULL terminated UCS-2 string. In order to define a UCS-2 string literal,
> kernel.img on amd64 and i386 EFI targets is built with -fshort-wchar.
>
> Also compile kernel.img on other EFI targets with -fshort-wchar.
>
> Fixes: 37ddd94 (kern/efi/init: Log a console error during a stack check
> failure)
>
> Signed-off-by: Chris Coulson <chris.coulson@canonical.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
Thank you for fixing this!
Daniel