grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH V2 3/4] bash-completion:fix shellcheck SC2155-Warning


From: Daniel Kiper
Subject: Re: [PATCH V2 3/4] bash-completion:fix shellcheck SC2155-Warning
Date: Thu, 1 Dec 2022 20:18:12 +0100

On Wed, Nov 30, 2022 at 04:30:59PM +0800, t.feng wrote:
> In grub-completion.bash.in line 115:
>     local config_file=$(__grub_dir)/grub.cfg
>           ^---------^ SC2155 (warning)
>
> In grub-completion.bash.in line 126:
>     local grub_dir=$(__grub_dir)
>           ^------^ SC2155 (warning)

Please add at least one sentence of description to the commit message
why this patch is needed. Otherwise almost everybody has to take a look
at the link below what the warning means. Though link may stay as is...

> ref:https://github.com/koalaman/shellcheck/wiki/SC2155

Please drop "ref:" or replace it with "More: ". Same applies to the
other patches.

> Signed-off-by: "t.feng" <fengtao40@huawei.com>

Daniel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]