[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] kern/file: Fix error handling in grub_file_open()
|
From: |
Daniel Kiper |
|
Subject: |
Re: [PATCH] kern/file: Fix error handling in grub_file_open() |
|
Date: |
Tue, 6 Dec 2022 16:21:31 +0100 |
|
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Tue, Dec 06, 2022 at 01:45:11AM +0000, Steve McIntyre wrote:
> grub_file_open() calls grub_file_get_device_name(), but doesn't check
> the return. Instead, it checks if grub_errno is set.
>
> However, nothing initialises grub_errno here when grub_file_open()
> starts. This means that trying to open one file that doesn't exist and
> then trying to open another file that does will (incorrectly) also
> fail to open that second file.
>
> Let's fix that.
>
> Signed-off-by: Steve McIntyre <steve@einval.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
Daniel