Re: AW: AW: Adding --set to videoinfo to retrieve current video resolution

[Daniel Kiper]

On Tue, Dec 13, 2022 at 07:06:51PM +0800, Zhang Boyang wrote:
> Hi,
>
> On 2022/12/12 19:09, Markus Scholz wrote:
> > Hi,
> >
> > thank you again for your reply and explanation. Despite the different
> > focus, I am still looking forward to try out your additions.
> >
> > Regarding my videoinfo patch I submitted them using git to the mailing
> > list. What is the best way forward here?
> >
>
> Maybe the only thing what can do now is wait... If you think the maintainers
> forget you patches, you can resend them like [PATCH RESEND 1/1] after few
> days/weeks.
>
> > Since its just a single file and no deep changes maybe the effort is no too
> > much... Would you be so kind/able to review them or should I reach out to
> > Daniel for this?
>
> I'm not a maintainer of GRUB, so I'm not sure whether I have rights to send
> Reviewed-By tags. Although I think I can give some advice for these patches.

I am OK with everybody giving RB if them reviewed patches and they seem
OK with the code. Though I reserve right to add some more comments and final
decision to include or not the patch in the upstream.

> I think you can reach out to Daniel if you think these patches are
> forgotten.

I try to follow this (and other) threads but I count on you to work out
final solution. If I see anything which does not work for me I will jump
in and comment. When the patch set is ready for my review drop me a line
and I will take a look at it.

> > Since I am new to the grub process I am not sure how to get the changes in.
>
> I'm also new to GRUB (and other open source projects).... So please forgive
> me if I said something misleading.

You are doing good guys. Thank you!

Daniel