Re: [PATCH 3/7] ns8250: Add base support for MMIO UARTs

[Benjamin Herrenschmidt]

Thanks for your review !

I'll  address everything. Small "nits":

On Wed, 2022-12-21 at 14:25 +0100, Daniel Kiper wrote:
> > +
> > +char *
> > +grub_serial_ns8250_add_mmio(grub_addr_t addr)
> > +{
> > +  struct grub_serial_port *p;
> > +  unsigned i;
> 
> Please add en empty line here.

Ack. I copied grub_serial_ns8250_add_port() :-) I'll fix that one as
well

> > +  for (i = 0; i < GRUB_SERIAL_PORT_NUM; i++)
> > +    if (com_ports[i].mmio &&  com_ports[i].mmio_base == addr)
> > +       return com_names[i];
> > +
> > +  p = grub_malloc (sizeof (*p));
> > +  if (!p)
> 
> I prefer "p == NULL" instead of "!p". If you could fix that here and in
> the other places/patches that will be nice.

Ditto (pre-existing construct).

I'll fix them in the other code too, holler if you object.

Cheers,
Ben.