Re: [PATCH 1/2] tests: Return hard error for functional test when unicode.pf2 does not exist

[Thomas Schmitt]

Hi,

On Thu, 16 Feb 2023 01:15:00 -0600, Glenn Washburn
<development@efficientek.com> wrote:
> The functional test requires unicode.pf2 to run successfully, so
> explicitly have the test return ERROR when its not found.
>
> Signed-off-by: Glenn Washburn <development@efficientek.com>
> ---
>  tests/grub_func_test.in | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/tests/grub_func_test.in b/tests/grub_func_test.in
> index c67f9e4225..d43427c568 100644
> --- a/tests/grub_func_test.in
> +++ b/tests/grub_func_test.in
> @@ -3,6 +3,11 @@ set -e
>
>  . "@builddir@/grub-core/modinfo.sh"
>
> +if [ ! -e "@builddir@/"unicode.pf2 ]; then
> +  echo "Functional test requires grub-mkfont support"
> +  exit 99
> +fi
> +
>  case "${grub_modinfo_target_cpu}-${grub_modinfo_platform}" in
>      # PLATFORM: Max RAM is 256M
>      mips-qemu_mips | mipsel-qemu_mips)

Tested-by: Thomas Schmitt <scdbackup@gmx.net>


With xfonts-unifont installed, the test gets beyond the grub-mkisofs run
and shows the usual complaints about checksums.

After
  apt-get remove xfonts-unifont
and in the git repo:
  rm unicode.pf2
  ./configure && make
the grub_func_test ends very quickly with:

  Functional test requires grub-mkfont support
  ERROR grub_func_test (exit status: 99)


Have a nice day :)

Thomas