Re: [PATCH v2] osdep/hurd/getroot: Remove unused variables in grub_util_find_hurd_root_device()

[Samuel Thibault]

John Paul Adrian Glaubitz, le mer. 22 févr. 2023 09:43:02 +0100, a ecrit:
> Found during a test build on Debian/hurd-i386 with --disable-werror enabled:
> 
> In file included from grub-core/osdep/getroot.c:12:
> grub-core/osdep/hurd/getroot.c: In function ‘grub_util_find_hurd_root_device’:
> grub-core/osdep/hurd/getroot.c:126:13: error: unused variable ‘next’ 
> [-Werror=unused-variable]
>   126 |       char *next;
>       |             ^~~~
> grub-core/osdep/hurd/getroot.c:125:14: error: unused variable ‘size’ 
> [-Werror=unused-variable]
>   125 |       size_t size;
>       |              ^~~~
> 
> Fixes: e981b0a24 (osdep/hurd/getroot: Use "part:" qualifier)
> 
> Signed-off-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>

Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

Thanks!

> ---
> v2:
> - Add missing Fixes tag
> ---
>  grub-core/osdep/hurd/getroot.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/grub-core/osdep/hurd/getroot.c b/grub-core/osdep/hurd/getroot.c
> index af31f2c47..0efefdab4 100644
> --- a/grub-core/osdep/hurd/getroot.c
> +++ b/grub-core/osdep/hurd/getroot.c
> @@ -122,8 +122,6 @@ grub_util_find_hurd_root_device (const char *path)
>    if (strncmp (name, "device:", sizeof ("device:") - 1) == 0)
>      {
>        char *dev_name = name + sizeof ("device:") - 1;
> -      size_t size;
> -      char *next;
>  
>        if (dev_name[0] == '@')
>          {
> -- 
> 2.39.1
>