Re: [PATCH 5/8] gdb: Add functions to make loading from dynamically positioned targets easier

[Daniel Kiper]

On Mon, Feb 27, 2023 at 03:15:35PM -0600, Glenn Washburn wrote:
> Many targets, such as EFI, load GRUB at addresses that are determined at
> runtime. So the load addresses in kernel.exec will almost certainly be
> wrong. Given the address of the start of the text segment, these
> functions will tell GDB to load the symbols at the proper locations. It
> is left up to the user to determine how to get the text address of the
> loaded GRUB image.
>
> Signed-off-by: Glenn Washburn <development@efficientek.com>
> ---
>  grub-core/gdb_grub.in      | 21 ++++++++-
>  grub-core/gdb_helper.py.in | 87 ++++++++++++++++++++++++++++++++++++++
>  2 files changed, 107 insertions(+), 1 deletion(-)
>
> diff --git a/grub-core/gdb_grub.in b/grub-core/gdb_grub.in
> index fc201204debc..18ce6b0eb2d4 100644
> --- a/grub-core/gdb_grub.in
> +++ b/grub-core/gdb_grub.in
> @@ -1,6 +1,6 @@
>  ###
>  ### Load debuging information about GNU GRUB 2 modules into GDB
> -### automatically. Needs readelf, Python and gdb_helper.py script
> +### automatically. Needs readelf, objdump, Python and gdb_helper.py script

Could you add a patch which creates a separate section in the INSTALL
file with a list of required packages needed to do GRUB debugging?

Otherwise for all the patches Reviewed-by: Daniel Kiper 
<daniel.kiper@oracle.com>...

Daniel