[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 09/10] commands/bli: Extract uft8 to utf16 conversion
|
From: |
Daniel Kiper |
|
Subject: |
Re: [PATCH v3 09/10] commands/bli: Extract uft8 to utf16 conversion |
|
Date: |
Wed, 8 Mar 2023 16:13:38 +0100 |
|
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Thu, Mar 02, 2023 at 07:20:44PM +0100, Oliver Steffen wrote:
> Create a new function for utf-8 to utf-16 conversion called
> `grub_utf8_to_utf16_alloc` in the bli module. It is modeled after the
s/`grub_utf8_to_utf16_alloc`/grub_utf8_to_utf16_alloc()/
> `grub_utf8_to_ucs4_alloc` like functions in charset.h. The goal is to
s/`grub_utf8_to_ucs4_alloc`/grub_utf8_to_ucs4_alloc()/
> move this to a central place so that it can help reduce code
> duplication.
>
> Please comment: Where should this go?
I would put it in grub-core/normal/charset.c. If not then grub-core/kern/misc.c.
Daniel
- [PATCH v3 02/10] efi: Check for integer overflow in string conversion, (continued)
- [PATCH v3 02/10] efi: Check for integer overflow in string conversion, Oliver Steffen, 2023/03/02
- [PATCH v3 05/10] grub-core: Make use of guid printf format specifier, Oliver Steffen, 2023/03/02
- [PATCH v3 06/10] Add a module for the Boot Loader Interface, Oliver Steffen, 2023/03/02
- [PATCH v3 08/10] types.h: Add GRUB_SSIZE_MAX, Oliver Steffen, 2023/03/02
- [PATCH v3 10/10] util/grub.d: Activate bli module on EFI, Oliver Steffen, 2023/03/02
- [PATCH v3 09/10] commands/bli: Extract uft8 to utf16 conversion, Oliver Steffen, 2023/03/02
- Re: [PATCH v3 09/10] commands/bli: Extract uft8 to utf16 conversion,
Daniel Kiper <=