[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1] emu/linux: work around systemctl kexec returning
From: |
Daniel Kiper |
Subject: |
Re: [PATCH v1] emu/linux: work around systemctl kexec returning |
Date: |
Tue, 28 Mar 2023 15:51:45 +0200 |
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Thu, Mar 23, 2023 at 11:59:51AM -0400, Robbie Harwood wrote:
> Per systemctl(1), it "is asynchronous; it will return after the reboot
> operation is enqueued, without waiting for it to complete". This
> differs from kexec(8), which calls reboot(2) and therefore does not
> return.
>
> When not using fallback, this confusingly results in:
>
> error trying to perform 'systemctl kexec': 0
> Aborted. Press any key to exit.
>
> on screen for a bit, followed by successful kexec.
>
> To reduce the liklihood of hitting this case, add a delay on succesful
> return. Ultimately, the systemd interface is racy: we can't avoid it
> entirely unless we never fallback on success.
>
> Signed-off-by: Robbie Harwood <rharwood@redhat.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
Daniel