Re: [PATCH v15 00/10] Add LoongArch support

[Xiaotian Wu]

在 2023-04-25星期二的 17:11 +0200，Daniel Kiper写道：
> On Tue, Apr 18, 2023 at 08:04:07PM +0800, Xiaotian Wu wrote:
> > LoongArch is a new Loongson 3A5000 CPU instruction set, you can
> > read
> > documents [1] or visit the development community [2] to get more
> > information.
> > 
> > [1]:
> > https://loongson.github.io/LoongArch-Documentation/README-EN.html
> > [2]: https://github.com/loongson
> > 
> > This patch series adds support for the Loongarch architecture,
> > which can
> > compile and run the linux-6.2+ kernel on LoongArch.
> > 
> > Please review the patches, thank you.
> > 
> > v14->v15:
> > - Update test code to pass more test cases.
> 
> In general LGTM except a few things:
>   - please explain in the #10 commit message how did you run tests,
>     on which platform, why some tests fail, which failures/errors
>     can be safely ignored, etc.,
>   - please change 2022 year to 2023 in all copyright texts which you
> add,
>   - please use "asm volatile" instead of "__asm__ __volatile__",
>   - all casts should be in form "(grub_addr_t)(void *) var", extra
> space
>     before variable name, instead of "(grub_addr_t)(void *)var",
>   - in general stick to GRUB coding style [1].
> 
> Daniel

Thank you, it has been fixed, please see the v16 patch.
> [1]
> https://www.gnu.org/software/grub/manual/grub-dev/grub-dev.html#Coding-style
> 
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel

-- 
Best Regards
Xiaotian Wu