[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] efi: Fix stack protector issues
|
From: |
Vladimir 'phcoder' Serbinenko |
|
Subject: |
Re: [PATCH v2] efi: Fix stack protector issues |
|
Date: |
Wed, 17 Jan 2024 06:10:29 +0300 |
Looks good. A small comment inline
> diff --git a/grub-core/kern/main.c b/grub-core/kern/main.c
> index 731c07c29..5db504e6e 100644
> --- a/grub-core/kern/main.c
> +++ b/grub-core/kern/main.c
> @@ -265,6 +265,11 @@ reclaim_module_space (void)
> void __attribute__ ((noreturn))
> grub_main (void)
> {
> +#ifdef GRUB_STACK_PROTECTOR
> + /* This call can only be made from a function that does not return. */
Please add a bit of reasoning here not just in the commit message
--
Regards
Vladimir 'phcoder' Serbinenko