Re: [PATCH V5] ieee1275/ofdisk: retry on open and read failure

[Mukesh Kumar Chaurasiya]

On 1/25/24 10:35, Michael Chang wrote:

> On Wed, Jan 24, 2024 at 11:42:30AM +0530, Mukesh Kumar Chaurasiya wrote:
> > +
> > +  if (grub_strstr (disk->name, "fibre-channel") != NULL ||
> > +      grub_strstr (disk->name, "vfc-client") != NULL)
> Is there a reason why nvme-of now exempted from the retrying ? It was
> tested in v4 like this:
>
> +  if (!(grub_strstr (disk->name, "fibre-channel@") ||
> +      grub_strstr (disk->name, "vfc-client")) ||
> +      grub_strstr(disk->name, "nvme-of"))
> +    {
> +      /* Do not retry in case of non network drives */
> +      return 0;
> +    }
>
> Thanks,
> Michael

Well we wanted to remove all the non network drives and nvme-of hence 
the check was

 NOT(fibre-channel OR vfc-client) OR nvme-of

It was really confusing with all the negation and hence we made it 
simple to try only for the types of disk we want to.

Regards,

Mukesh

> > +    {
> > +      if (timeout == NULL)
> > +        {
> > +          return retry;
> > +        }
> > +      retry = grub_strtoul (timeout, &timeout_end, 10);
> > +      /* Ignore all errors and return default timeout */
> > +      if (grub_errno != GRUB_ERR_NONE ||
> > +          *timeout == '\0' ||
> > +          *timeout_end != '\0')
> > +        {
> > +          return RETRY_DEFAULT_TIMEOUT;
> > +        }
> > +    }
> > +  else
> > +    return 0;
> > +
> > +  return retry;
> > +}
> > +