Re: [PATCH] LVM Cachevol and Integrity volumes break entire LVM VG

[Patrick Plenefisch]

Thankfully, no further changes were actually necessary, so here is my
attempt to convert it to two patches

I attached the diffs, but also committed them to
https://github.com/byteit101/grub2/tree/grub-lvmintegrity


Patrick

On Thu, Feb 8, 2024 at 3:06 PM Daniel Kiper <dkiper@net-space.pl> wrote:
>
> On Thu, Feb 08, 2024 at 02:52:37PM -0500, Patrick Plenefisch wrote:
> > Hmm, what would the logical parts be? The solution for both cachevol and
> > integrity is the same.
>
> It seems to me at least code refactoring which you are doing could be
> taken out to a separate patch. Maybe something else... Anyway, in general
> smaller patches ease reviewing...
>
> > I do know another part needs to be added as I still need to investigate some
> > warnings, but I'll likely need to do that this weekend when I have some more
> > time.
>
> Cool! Thanks!
>
> Daniel

second.diff
Description: Source code patch

first.diff
Description: Source code patch