Re: [PATCH v2] Track explicit module dependencies in Makefile.core.def

[Oskari Pirhonen]

On Wed, Feb 28, 2024 at 13:36:00 +0100, Oliver Steffen wrote:
> Add a new keyword, "depends", to the module definition syntax
> used in Makefile.core.def. This allows specifying explicit module
> dependencies together with the module definition.
> 
> Do not track the "extra_deps.lst" file in the repository anymore,
> it is now auto-generated.
> 
> Make use of this new keyword in the bli module definition.
> 
> Signed-off-by: Oliver Steffen <osteffen@redhat.com>
> Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
> ---
> v2:
> - fix out-of-source builds
> 

This fixes the build issue I mentioned in v1 based on running through
the same steps again.

However, it feels like there are two distinct things going on in this
patch:

1. Code to generate the extra_deps.lst at make-time using the new
   "depends" keyword
2. Use the new "depends" keyword for the bli module

Would it make more sense to split this patch into two?

Otherwise,

Tested-by: Oskari Pirhonen <xxc3ncoredxx@gmail.com>

- Oskari


Side note, overall this change is simpler than I expected.

signature.asc
Description: PGP signature