Re: [PATCH v5 1/2] fs/erofs: Add support for EROFS

[Gao Xiang]

Hi Gleen, Daniel,

On 2024/4/5 04:56, Daniel Kiper wrote:
> On Wed, Mar 06, 2024 at 10:18:21AM +0800, Gao Xiang wrote:
> > On 2024/3/4 01:15, Yifan Zhao wrote:
> > > EROFS [1] is a lightweight read-only filesystem designed for performance
> > > which has already been shipped in most Linux distributions as well as widely
> > > used in several scenarios, such as Android system partitions, container
> > > images, and rootfs for embedded devices.
> > >
> > > This patch brings EROFS uncompressed support. Now, it's possible to boot
> > > directly through GRUB with an EROFS rootfs.
> > >
> > > EROFS compressed files will be supported later since it has more work to
> > > polish.
> > >
> > > [1] https://erofs.docs.kernel.org
> > >
> > > Signed-off-by: Yifan Zhao <zhaoyifan@sjtu.edu.cn>
> >
> > After checking the v4->v5 diff, it still looks good to me,
> > Reviewed-by: Gao Xiang <hsiangkao@linux.alibaba.com>
> >
> > BTW, Glenn, would you mind taking some time checking if
> > this version looks good to you? Thanks a lot!
>
> Glenn, Do you have any comments on this version of EROFS patch set?

Yeah, friendly ping.. Thanks in advance!


There is the diffs from the latest reviewed version (v2):

v2(last reviewed)->v4: 
https://lore.kernel.org/r/20240303171739.801243-1-zhaoyifan@sjtu.edu.cn
v4->v5: https://lore.kernel.org/r/20240303171558.800691-1-zhaoyifan@sjtu.edu.cn

Could we have some progress on uncompressed EROFS so that it can
be used for GRUB?  Then we will focus on upstreaming compression
support.

Thanks again!
Gao Xiang

> Daniel