[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/4] Various test fixes proposed by Thomas Schmitt
From: |
Thomas Schmitt |
Subject: |
Re: [PATCH 0/4] Various test fixes proposed by Thomas Schmitt |
Date: |
Thu, 26 Sep 2024 22:44:20 +0200 |
Hi,
i wrote:
> > I meanwhile forgot why i proposed
> > > + unset TMPDIR
> > but there was some theoretical reason for this ...
Glenn Washburn wrote:
> My guess was that you wanted to unexport TMPDIR.
Yes. The reason was that i wanted to limit the effect of exporting to
the run of grub-shell-luks-tester, just in case that any further code
does not expect exported TMPDIR.
> > LUKS2 test with argon2 pbkdf: XFAIL
> XFAIL means "expected fail", so its okay.
But why doesn't it clean up then ?
This particular sub-test leaves not only the empty ./mnt firectory but
also a 20 MB device image (?) and some small data files.
All other sub-tests of tests/grub_cmd_cryptomount leave a neatly empty
directory which grub_cmd_cryptomount can rmdir after the sub-test is done.
Have a nice day :)
Thomas
- [PATCH 0/4] Various test fixes proposed by Thomas Schmitt, Glenn Washburn, 2024/09/23
- [PATCH 1/4] tests/util/grub-shell-luks-tester: Add missing line to create RET variable in cleanup, Glenn Washburn, 2024/09/23
- [PATCH 2/4] tests: Cleaup the cryptsetup script in grub_cmd_cryptomount unless debug is enabled, Glenn Washburn, 2024/09/23
- [PATCH 3/4] tests: Default TMPDIR to /tmp in grub_cmd_cryptomount tests, Glenn Washburn, 2024/09/23
- [PATCH 4/4] tests/util/grub-shell: Remove the work directory on successful run and debug is not on, Glenn Washburn, 2024/09/23
- Re: [PATCH 0/4] Various test fixes proposed by Thomas Schmitt, Thomas Schmitt, 2024/09/23