[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Guile-commits] 01/12: Fix compilation of rank 0 typed array literals
From: |
Daniel Llorens |
Subject: |
[Guile-commits] 01/12: Fix compilation of rank 0 typed array literals |
Date: |
Fri, 18 Nov 2016 16:54:45 +0000 (UTC) |
lloda pushed a commit to branch lloda-squash1
in repository guile.
commit a177ee3005e450774a34cd8412521aae2972fabc
Author: Daniel Llorens <address@hidden>
Date: Thu Feb 12 13:02:24 2015 +0100
Fix compilation of rank 0 typed array literals
* module/system/vm/assembler.scm (simple-uniform-vector?): array-length
fails for rank 0 arrays; fix the shape condition.
* test-suite/tests/arrays.test: Test reading of #0f64(x) in compilation
context.
---
module/system/vm/assembler.scm | 4 +++-
test-suite/tests/arrays.test | 8 +++++++-
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/module/system/vm/assembler.scm b/module/system/vm/assembler.scm
index 96c6a63..5b89b04 100644
--- a/module/system/vm/assembler.scm
+++ b/module/system/vm/assembler.scm
@@ -1001,7 +1001,9 @@ immediate, and @code{#f} otherwise."
(define (simple-uniform-vector? obj)
(and (array? obj)
(symbol? (array-type obj))
- (equal? (array-shape obj) (list (list 0 (1- (array-length obj)))))))
+ (match (array-shape obj)
+ (((0 n)) #t)
+ (else #f))))
(define (statically-allocatable? x)
"Return @code{#t} if a non-immediate constant can be allocated
diff --git a/test-suite/tests/arrays.test b/test-suite/tests/arrays.test
index e76c699..20cb78b 100644
--- a/test-suite/tests/arrays.test
+++ b/test-suite/tests/arrays.test
@@ -204,7 +204,13 @@
(with-test-prefix/c&e "array-equal?"
(pass-if "#s16(...)"
- (array-equal? #s16(1 2 3) #s16(1 2 3))))
+ (array-equal? #s16(1 2 3) #s16(1 2 3)))
+
+ (pass-if "#0f64(...)"
+ (array-equal? #0f64(99) (make-typed-array 'f64 99)))
+
+ (pass-if "#0(...)"
+ (array-equal? #0(99) (make-array 99))))
;;;
;;; make-shared-array
- [Guile-commits] branch lloda-squash1 created (now 3c93e37), Daniel Llorens, 2016/11/18
- [Guile-commits] 03/12: Reuse SCM_BYTEVECTOR_TYPED_LENGTH in scm_array_get_handle, Daniel Llorens, 2016/11/18
- [Guile-commits] 01/12: Fix compilation of rank 0 typed array literals,
Daniel Llorens <=
- [Guile-commits] 11/12: Document new array functions, Daniel Llorens, 2016/11/18
- [Guile-commits] 08/12: Do not use array handles in scm_vector, Daniel Llorens, 2016/11/18
- [Guile-commits] 07/12: Special case for array-map! with three arguments, Daniel Llorens, 2016/11/18
- [Guile-commits] 02/12: Avoid unneeded internal use of array handles, Daniel Llorens, 2016/11/18
- [Guile-commits] 04/12: Remove deprecated array functions, Daniel Llorens, 2016/11/18
- [Guile-commits] 06/12: Speed up for multi-arg cases of scm_ramap functions, Daniel Llorens, 2016/11/18
- [Guile-commits] 05/12: Support typed arrays in some sort functions, Daniel Llorens, 2016/11/18
- [Guile-commits] 09/12: New functions array-from, array-from*, array-amend!, Daniel Llorens, 2016/11/18
- [Guile-commits] 10/12: New functions (array-for-each-cell, array-for-each-cell-in-order), Daniel Llorens, 2016/11/18
- [Guile-commits] 12/12: Deprecate scm_from_contiguous_array, Daniel Llorens, 2016/11/18