[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] nonblocking write/recv/send/connect/accept
From: |
Marius Vollmer |
Subject: |
Re: [PATCH] nonblocking write/recv/send/connect/accept |
Date: |
29 Jun 2002 13:50:16 +0200 |
User-agent: |
Gnus/5.09 (Gnus v5.9.0) Emacs/21.2 |
Christopher Cramer <address@hidden> writes:
> On Sat, Jun 01, 2002 at 05:58:29PM +0200, Marius Vollmer wrote:
> > Could you try to collect this pattern into its own set of functions
> > (ala fport_wait_for_input)? I think this will make the code much
> > cleaner.
>
> One thing is, we need functions in both socket.c and fports.c, and
> fport_wait_for_input is static. Should I put the functions in both files,
> or make them extern?
The point is to collect similar code, so I'd say we should have only
one copy of a function. Also, there might be more opportunities to
use it in the future. A good place to put it would be iselect.c, I
think.