[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
267/376: Remove comments claiming we use a private PID namespace
From: |
Ludovic Courtès |
Subject: |
267/376: Remove comments claiming we use a private PID namespace |
Date: |
Wed, 28 Jan 2015 22:05:31 +0000 |
civodul pushed a commit to tag 1.8
in repository guix.
commit 11aef17a774c923b7ec88ea1f4bb453452339a2a
Author: Eelco Dolstra <address@hidden>
Date: Wed Oct 29 15:49:03 2014 +0100
Remove comments claiming we use a private PID namespace
This is no longer the case since
524f89f1399724e596f61faba2c6861b1bb7b9c5.
---
src/libstore/build.cc | 9 +--------
1 files changed, 1 insertions(+), 8 deletions(-)
diff --git a/src/libstore/build.cc b/src/libstore/build.cc
index 3c9db5f..e8067ac 100644
--- a/src/libstore/build.cc
+++ b/src/libstore/build.cc
@@ -1926,12 +1926,6 @@ void DerivationGoal::initChild()
/* Set up private namespaces for the build:
- - The PID namespace causes the build to start as PID 1.
- Processes outside of the chroot are not visible to
- those on the inside, but processes inside the chroot
- are visible from the outside (though with different
- PIDs).
-
- The private mount namespace ensures that all the bind
mounts we do will only show up in this process and
its children, and will disappear automatically when
@@ -2032,8 +2026,7 @@ void DerivationGoal::initChild()
throw SysError(format("bind mount from ‘%1%’ to ‘%2%’
failed") % source % target);
}
- /* Bind a new instance of procfs on /proc to reflect our
- private PID namespace. */
+ /* Bind a new instance of procfs on /proc. */
createDirs(chrootRootDir + "/proc");
if (mount("none", (chrootRootDir + "/proc").c_str(), "proc", 0, 0)
== -1)
throw SysError("mounting /proc");
- 260/376: Drop support for pre-c++11 compilers., (continued)
- 260/376: Drop support for pre-c++11 compilers., Ludovic Courtès, 2015/01/28
- 262/376: Revert "Drop support for pre-c++11 compilers.", Ludovic Courtès, 2015/01/28
- 263/376: Fix build on gcc < 4.7, Ludovic Courtès, 2015/01/28
- 244/376: Show total allocations, Ludovic Courtès, 2015/01/28
- 293/376: Remove Hydra build product, Ludovic Courtès, 2015/01/28
- 279/376: Add a launchd configuration file to run nix-daemon, Ludovic Courtès, 2015/01/28
- 251/376: nix-channel --add: Validate URL / channel ID, Ludovic Courtès, 2015/01/28
- 252/376: Remove redundant space in usage errors, Ludovic Courtès, 2015/01/28
- 290/376: realiseContext: Handle all context types, Ludovic Courtès, 2015/01/28
- 276/376: Improve error message if the daemon worker fails to start, Ludovic Courtès, 2015/01/28
- 267/376: Remove comments claiming we use a private PID namespace,
Ludovic Courtès <=
- 237/376: Don't recompile the same regex over and over, Ludovic Courtès, 2015/01/28
- 297/376: Build Ubuntu 14.10 package, Ludovic Courtès, 2015/01/28
- 268/376: Document some primops, Ludovic Courtès, 2015/01/28
- 272/376: Shut up a clang warning, Ludovic Courtès, 2015/01/28
- 257/376: Revert "binary download: Use $NIX_CURL_FLAGS", Ludovic Courtès, 2015/01/28
- 266/376: doc: fixed nix-instantiate --find-file, Ludovic Courtès, 2015/01/28
- 282/376: download-from-binary-cache.pl: Fix flushing of stderr, Ludovic Courtès, 2015/01/28
- 256/376: Merge pull request #372 from wmertens/patch-4, Ludovic Courtès, 2015/01/28
- 280/376: Typo, Ludovic Courtès, 2015/01/28
- 281/376: nix-store --gc: Don't warn about missing manifests directory, Ludovic Courtès, 2015/01/28