06/07: gnu: go-github-com-wtolson-go-taglib: Fix tests and build for go-1.11.

[Pierre Neidhardt]

ambrevar pushed a commit to branch master
in repository guix.

commit 46a4ae2212d72d38dc55188e35a7441964694f91
Author: Pierre Neidhardt <address@hidden>
Date:   Tue Nov 6 18:11:21 2018 +0100

    gnu: go-github-com-wtolson-go-taglib: Fix tests and build for go-1.11.
    
    * gnu/packages/golang.scm (go-github-com-wtolson-go-taglib)[arguments]: Fix 
tests for go-1.11.
    [native-inputs]: Remove pkg-config and taglib.
    [propagated-inputs]: Add pkg-config and taglib.
---
 gnu/packages/golang.scm | 17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 5b84ced..2fd8bf4 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -2419,11 +2419,24 @@ and lookup requests.  Browse requests are not supported 
yet.")
           (base32
            "1cpjqnrviwflz150g78iir5ndrp3hh7a93zbp4dwbg6sb2q141p2"))))
       (build-system go-build-system)
-      (native-inputs
+      ;; From go-1.10 onward, "pkg" compiled libraries are not re-used, so
+      ;; when this package required as input for another one, it will have to
+      ;; be built again.  Thus its CGO requirements must be made available in
+      ;; the environment, that is, they must be propagated.
+      (propagated-inputs
        `(("pkg-config" ,pkg-config)
          ("taglib" ,taglib)))
       (arguments
-       `(#:import-path "github.com/wtolson/go-taglib"))
+       `(#:import-path "github.com/wtolson/go-taglib"
+         ;; Tests don't pass "vet" on go-1.11.  See
+         ;; https://github.com/wtolson/go-taglib/issues/12.
+         #:phases
+         (modify-phases %standard-phases
+           (replace 'check
+             (lambda* (#:key import-path #:allow-other-keys)
+               (invoke "go" "test"
+                       "-vet=off"
+                       import-path))))))
       (home-page "https://github.com/wtolson/go-taglib";)
       (synopsis "Go wrapper for taglib")
       (description "Go wrapper for taglib")