01/12: guix package: Do not warn about "missing arguments" when there's nothing to do.

[guix-commits]

civodul pushed a commit to branch master
in repository guix.

commit f8c4437f0f60f24031170b16482b1d4fc4632918
Author: Ludovic Courtès <ludo@gnu.org>
AuthorDate: Fri May 28 15:41:32 2021 +0200

    guix package: Do not warn about "missing arguments" when there's nothing to 
do.
    
    In some cases, running "guix upgrade" can trigger this warning, and
    "missing arguments" is misleading then.
    
    Reported by flatwhatson on #guix.
    
    * guix/scripts/package.scm (process-actions): Change warning to "nothing
    to do".
---
 guix/scripts/package.scm | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/guix/scripts/package.scm b/guix/scripts/package.scm
index 52e9961..6db8380 100644
--- a/guix/scripts/package.scm
+++ b/guix/scripts/package.scm
@@ -1045,7 +1045,12 @@ processed, #f otherwise."
       (warn-about-old-distro)
 
       (when (and (null? files) (manifest-transaction-null? trans))
-        (warning (G_ "missing arguments, nothing to do~%")))
+        ;; We can reach this point because the user did not specify any action
+        ;; (as in "guix package"), did not specify any package (as in "guix
+        ;; install"), or because there's nothing to upgrade (as when running
+        ;; "guix upgrade" on an up-to-date profile).  We cannot distinguish
+        ;; among these here; all we can say is that there's nothing to do.
+        (warning (G_ "nothing to do~%")))
 
       (unless (manifest-transaction-null? trans)
         ;; When '--manifest' is used, display information about TRANS as if we