01/11: inferior: 'cached-channel-instance' does not cache unauthenticated instances.

[guix-commits]

civodul pushed a commit to branch master
in repository guix.

commit 9f371f23ebfa20f70b3bfd55dc459b683f21ba91
Author: Ludovic Courtès <ludo@gnu.org>
AuthorDate: Tue Nov 30 11:19:30 2021 +0100

    inferior: 'cached-channel-instance' does not cache unauthenticated 
instances.
    
    The comment saying that caching is fine even when AUTHENTICATE? is false
    was true in commit 838ac881ec98cb71d4a4e4b20773573f99ecbf25, but it
    became incorrect in 7cfd789150f448cf5256b88915bae4163cc9db03, which
    no longer calls 'latest-channel-instances' on cache hits.
    
    * guix/inferior.scm (cached-channel-instance): Do not create CACHED when
    AUTHENTICATE? is false.
---
 guix/inferior.scm | 17 ++++++++++++-----
 1 file changed, 12 insertions(+), 5 deletions(-)

diff --git a/guix/inferior.scm b/guix/inferior.scm
index 81958ba..febac29 100644
--- a/guix/inferior.scm
+++ b/guix/inferior.scm
@@ -785,6 +785,9 @@ determines whether CHANNELS are authenticated."
   (define add-indirect-root*
     (store-lift add-indirect-root))
 
+  (define add-temp-root*
+    (store-lift add-temp-root))
+
   (mkdir-p cache-directory)
   (maybe-remove-expired-cache-entries cache-directory
                                       cache-entries
@@ -805,11 +808,15 @@ determines whether CHANNELS are authenticated."
             ;; what's going to be built.
             (built-derivations (list profile))
 
-            ;; Note: Caching is fine even when AUTHENTICATE? is false because
-            ;; we always call 'latest-channel-instances?'.
-            (symlink* (derivation->output-path profile) cached)
-            (add-indirect-root* cached)
-            (return cached))))))
+            ;; Cache if and only if AUTHENTICATE? is true.
+            (if authenticate?
+                (mbegin %store-monad
+                  (symlink* (derivation->output-path profile) cached)
+                  (add-indirect-root* cached)
+                  (return cached))
+                (mbegin %store-monad
+                  (add-temp-root* profile)
+                  (return profile))))))))
 
 (define* (inferior-for-channels channels
                                 #:key