guix-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

170/172: build/go: fix-embed-files: Adjust procedure docstring.


From: guix-commits
Subject: 170/172: build/go: fix-embed-files: Adjust procedure docstring.
Date: Sat, 9 Nov 2024 16:45:15 -0500 (EST)

sharlatan pushed a commit to branch master
in repository guix.

commit 07c00e13eb910ea746cb52696227b1f97d4aafe4
Author: Sharlatan Hellseher <sharlatanus@gmail.com>
AuthorDate: Thu Sep 26 19:57:23 2024 +0100

    build/go: fix-embed-files: Adjust procedure docstring.
    
    This is a follow up adjustment, proposed by Maxim Cournoyer
    <maxim.cournoyer@gmail.com> in <https://issues.guix.gnu.org/73299>.
    
    * guix/build/go-build-system.scm (fix-embed-files): Improve the grammar
    and style, and provide a URL to the raw source file for reference.
    
    Change-Id: I78824b92d70a2431f61d11e8737bca6a2ddea3fa
---
 guix/build/go-build-system.scm | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/guix/build/go-build-system.scm b/guix/build/go-build-system.scm
index 14cb5ae687..e53d8cb53c 100644
--- a/guix/build/go-build-system.scm
+++ b/guix/build/go-build-system.scm
@@ -205,16 +205,18 @@ dependencies, so it should be self-contained."
   #t)
 
 (define* (fix-embed-files #:key embed-files #:allow-other-keys)
-  "Golang can't determine the valid directory of the module of embed file
-which is symlinked during setup environment phase, but easy resolved after
-coping file from the store to the build directory of the current package. Take
-a list of files or regexps matching files from EMBED-FILES paramter, failover
-to 'editions_defaults.binpb' which is a part of <github.com/golang/protobuf>."
-  ;; see details in Golang source:
+  "Golang cannot determine the valid directory of the module of an embed file
+which is symlinked during setup environment phase, but easily resolved after
+copying the file from the store to the build directory of the current package.
+Take a list of files or regexps matching files from EMBED-FILES parameter,
+fail over to 'editions_defaults.binpb' which is a part of
+<github.com/golang/protobuf>."
+  ;; For the details, consult the Golang source:
   ;;
-  ;; - URL: <https://github.com/golang/go/blob/>
+  ;; - URL: <https://raw.githubusercontent.com/golang/go/>
   ;; - commit: 82c14346d89ec0eeca114f9ca0e88516b2cda454
-  ;; - file: src/cmd/go/internal/load/pkg.go#L2059
+  ;; - file: src/cmd/go/internal/load/pkg.go
+  ;; - line: 2059
   (let ((embed-files (format #f "^(~{~a|~}~a)$"
                              embed-files
                              "editions_defaults.binpb")))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]