Re: [PATCH 1/2] gnu: Add datefudge.

[Ludovic Courtès]

Cyril Roelandt <address@hidden> skribis:

> * gnu/packages/datefudge.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.

Fine, modulo minor stylistic issues:

> +             (uri (string-append
> +                   "http://ftp.de.debian.org/debian/pool/main/d/";
> +                   "datefudge/datefudge_" version ".tar.gz"))

(Eventually we should add ‘debian’ to %mirrors in guix/download.scm.)

> +        (alist-replace
> +         'configure
> +         (lambda* (#:key version outputs #:allow-other-keys #:rest args)
> +          (pk version outputs)

Leftover debugging statements, and ‘version’ doesn’t exist.

What you can do is use:

  (arguments
    `( ...
       ,version
       ...
      ))

to paste the ‘version’ field of the package being defined in the
quasiquote expression.

> +           (substitute* "Makefile"
> +             (("^VERSION.*$") (string-append "VERSION=" version)))
> +           ;; We do not need to pass these flags to "install".
> +           (substitute* "Makefile"

No need to repeat ‘substitute*’: there can be several substitutations in
a substitute* form.

> +           (substitute* "Makefile"
> +             (("^prefix.*$") (string-append "prefix=" out "\n")))))

Ditto.

> +    (inputs `(("perl" ,perl))) ; Needed for the tests.

‘native-inputs’, probably (if it were being cross-compiled, you’d want
to run the native Perl, right?).

Thanks!

Ludo’.