Re: Python-build-system does not honour phases

[Andreas Enge]

On Tue, Sep 10, 2013 at 07:48:30PM +0200, Ludovic Courtès wrote:
> You’re mixing different things: the line above is on the host side,
> whereas the patch I proposed changes the modules imported on the build
> side.

Okay, I get it!

> Can you try this patch to check the value of ‘phases’?

Without your previous patch, I get the following:

;;; (the-python-phases ((set-paths . #<procedure set-paths (#:key target inputs 
native-inputs search-paths native-search-paths)>) (unpack . #<procedure unpack 
(#:key source)>) (patch . #<procedure patch (#:key patches patch-flags)>) 
(patch-source-shebangs . #<procedure patch-source-shebangs (#:key source)>) 
(configure . #<procedure configure (#:key target native-inputs inputs outputs 
configure-flags out-of-source?)>) (patch-generated-file-shebangs . #<procedure 
patch-generated-file-shebangs rest>) (build . #<procedure build (#:key 
make-flags parallel-build?)>) (check . #<procedure check (#:key target 
make-flags tests? test-target parallel-tests?)>) (install . #<procedure 1c90070 
at ice-9/eval.scm:264:7 %args>) (patch-shebangs . #<procedure patch-shebangs 
(#:key outputs patch-shebangs?)>) (strip . #<procedure strip (#:key target 
outputs strip-binaries? strip-command objcopy-command strip-flags 
strip-directories)>)))
WARNING: (guile-user): `%standard-phases' imported from both (guix build 
python-build-system) and (guix build gnu-build-system)


After applying your previous patch, I get this:

;;; (the-python-phases ((set-paths . #<procedure set-paths (#:key target inputs 
native-inputs search-paths native-search-paths)>) (unpack . #<procedure unpack 
(#:key source)>) (patch . #<procedure patch (#:key patches patch-flags)>) 
(patch-source-shebangs . #<procedure patch-source-shebangs (#:key source)>) 
(patch-generated-file-shebangs . #<procedure patch-generated-file-shebangs 
rest>) (build . #<procedure build empty>) (check . #<procedure check (#:key 
tests? test-target)>) (install . #<procedure b92230 at ice-9/eval.scm:264:7 
%args>) (wrap . #<procedure wrap (#:key inputs outputs)>) (patch-shebangs . 
#<procedure patch-shebangs (#:key outputs patch-shebangs?)>) (strip . 
#<procedure strip (#:key target outputs strip-binaries? strip-command 
objcopy-command strip-flags strip-directories)>)))


So indeed, your patch solves the confusion!

Thanks, I will push it then.

Andreas