guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Add Package Gl


From: Nikita Karetnikov
Subject: Re: Add Package Gl
Date: Sat, 28 Sep 2013 23:42:45 +0400

Minor issues…

>    #:use-module ((guix licenses) 
>                   #:renamer (symbol-prefix-proc 'license:))

It’d better to use 'l: as a prefix to avoid (license license:something).
You could also use #:select if it’s possible.

>    #:use-module (gnu packages fontutils))
>
>

Extra newline.

> (define-public glu
>   (package
>      (name "glu")

Should be indented like so:

(package
  (name "glu")

>      (source (origin
>             (method url-fetch)
>             (uri (string-append "ftp://ftp.freedesktop.org/pub/mesa/glu/glu-"; 
>                                    version ".tar.gz"))
>               (sha256
>               (base32 
> "0r72yyhj09x3krn3kn629jqbwyq50ji8w5ri2pn6zwrk35m4g1s3"))))

(source (origin
         (method url-fetch)
         (uri (string-append "ftp://ftp.freedesktop.org/pub/mesa/glu/glu-"; 
                             version ".tar.gz"))
         (sha256
          (base32 "0r72yyhj09x3krn3kn629jqbwyq50ji8w5ri2pn6zwrk35m4g1s3"))))

>      (description 
>         "GLU, or OpenGL Utility Library provides some higher-level 
> functionality 

(description 
 "GLU, or OpenGL Utility Library provides some higher-level functionality 

The rest of the file has the same problems.  But as Cyril said: “Other
than that, this looks good, thanks!”

Attachment: pgpdJybs6dHnR.pgp
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]