[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: Add IceCat.
|
From: |
Andreas Enge |
|
Subject: |
Re: [PATCH] gnu: Add IceCat. |
|
Date: |
Tue, 12 Nov 2013 22:06:28 +0100 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, Nov 11, 2013 at 10:34:36PM +0100, Ludovic Courtès wrote:
> Perhaps ‘substring’ instead of ‘string-copy’ (does pretty much the same
> thing, but the meaning is clearer IMO.)
Okay. I have no preference.
> (lambda _ ...) is enough (where ‘_’ is a convention to suggest that we
> don’t care about the arguments.)
Thanks, that is interesting to know!
> > + ;; delete dangling symlinks
> Do they cause problem with one of the patch-everything passes?
Yes.
> Other than that, it looks good to me.
Okay, I will push in a moment without trying to compile again, and let hydra
pick up any error.
Andreas