Re: [PATCH 3/6] gnu: Add libpeas.

[Ludovic Courtès]

Cyril Roelandt <address@hidden> skribis:

> On 11/30/2013 11:03 PM, Ludovic Courtès wrote:
>> Cyril Roelandt <address@hidden> skribis:
>>
>>> * gnu/packages/gnome.scm (libpeas): New variable.
>>
>> OK!
>>
>>> +         (lambda* (#:key inputs #:allow-other-keys #:rest args)
>>> +          (let ((configure (assoc-ref %standard-phases 'configure))
>>> +                (gir-path (lambda (pkg-name)
>>> +                           (string-append
>>> +                            (assoc-ref inputs pkg-name)
>>> +                            "/share/gir-1.0"))))
>>> +           (substitute* "libpeas-gtk/Makefile.in"
>>> +            (("--add-include-path")
>>> +             (string-append
>>> +               " --add-include-path=" (gir-path "atk")
>>> +               " --add-include-path=" (gir-path "gdk-pixbuf")
>>> +               " --add-include-path=" (gir-path "gtk+")
>>> +               " --add-include-path=" (gir-path "pango")
>>> +              " --add-include-path")))
>>
>> If this ‘gir-path’ thing is frequent, we should factorize it in a
>> build-side module, say (guix build gnome).  WDYT?
>>
>> (That shouldn’t block this particular patch, though.)
>>
>
> Yes, I think that every package using gobject-introspection will need
> a gir-path method. I guess I could implement it in (guix build gnome)
> in this patch.

Or that can be another patch later, so we can move forward; either way.

Ludo’.