[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/5] gnu: openssl: Fixed cross-compile issues.
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH 4/5] gnu: openssl: Fixed cross-compile issues. |
Date: |
Sat, 14 Dec 2013 22:01:46 +0100 |
User-agent: |
Gnus/5.130007 (Ma Gnus v0.7) Emacs/24.3 (gnu/linux) |
John Darrington <address@hidden> skribis:
> On Sat, Dec 14, 2013 at 06:57:59PM +0100, Ludovic Court??s wrote:
>
> > @@ -52,8 +52,8 @@
> > (string-append "--prefix=" out)))))
> > (alist-cons-before
> > 'patch-source-shebangs 'patch-tests
> > - (lambda* (#:key inputs #:allow-other-keys)
> > - (let ((bash (assoc-ref inputs "bash")))
> > + (lambda* (#:key inputs native-inputs #:allow-other-keys)
> > + (let ((bash (assoc-ref ,@(if (%current-target-system)
> '(native-inputs) '(inputs)) "bash")))
>
> This can???t possibly work.
>
> I did test it, both for native compilation and cross-compilation. In both
> cases
> it built succesfully (unlike before the patch).
Ah, sorry, I misread the unquoted part; apologies for that.
Still, I’d prefer the simpler (because it’s build-side code only):
(assoc-ref (or native-inputs inputs) "bash")
WDYT?
Could you send an updated patch if that’s fine with you?
Ludo’.
- Re: [PATCH 2/5] gnu: gnupg: Fixed cross-compile issues., (continued)
- Re: [PATCH 2/5] gnu: gnupg: Fixed cross-compile issues., Ludovic Courtès, 2013/12/14
- Re: [PATCH 2/5] gnu: gnupg: Fixed cross-compile issues., John Darrington, 2013/12/14
- Re: [PATCH 2/5] gnu: gnupg: Fixed cross-compile issues., Ludovic Courtès, 2013/12/14
- Re: [PATCH 2/5] gnu: gnupg: Fixed cross-compile issues., John Darrington, 2013/12/15
- [PATCH] gnu: gnupg: Fix cross-compile issues., John Darrington, 2013/12/15
- Re: [PATCH] gnu: gnupg: Fix cross-compile issues., Ludovic Courtès, 2013/12/15
- Re: [PATCH 2/5] gnu: gnupg: Fixed cross-compile issues., Ludovic Courtès, 2013/12/15
[PATCH 4/5] gnu: openssl: Fixed cross-compile issues., John Darrington, 2013/12/14
[PATCH 3/5] gnu: tzdata: Added "source" as input., John Darrington, 2013/12/14
[PATCH 5/5] gnu: Changed many "inputs" which should be "native-inputs"., John Darrington, 2013/12/14
Re: [PATCH 1/5] gnu: libxml2: Fixed cross-compilation., Ludovic Courtès, 2013/12/14