Fwd: Re: gnu : add GNU Mig

[Manolis Ragkousis]

By mistake I sent the patch only to ludo ,so I sent it again at guix devel

---------- Forwarded message ----------
From: "Manolis Ragkousis" <address@hidden>
Date: 20 Feb 2014 15:45
Subject: Re: gnu : add GNU Mig
To: "Ludovic Courtès" <address@hidden>
Cc:

1) Fixed the variable and package name to "mig"

2) Fixed the position of the backtick with M-x indent-region to be properly aligned

3) mig is not a binary but a script, but it still needs the build phase. You were right Ludo.

4) I wrapped the lines to ~75 chars

5) I took the description from the GNU mig website and make sync-descriptions doesn't say anything so I guess it's the right one.

I hope I did everything right this time :-)

2014-02-18 17:05 GMT+00:00 Ludovic Courtès <address@hidden>:

Manolis Ragkousis <address@hidden> skribis:

> My second patch for adding GNU Mig. :-D

Nice!  A couple of comments:

> +(define-public gnumig
> +  (package
> +    (name "gnumig")

The variable and package name should be ‘mig’ (‘gnumach’ is one of the
exceptions to the rule.)

> +    (arguments
> +    `(#:configure-flags '("TARGET_CPPFLAGS=-I /include" "--build=i686-pc-gnu")

Note that the backtick should be aligned with the ‘a’ of ‘arguments’.
If you use Emacs, pass the _expression_ through M-x indent-region.

> +      #:phases (alist-delete
> +                'build
> +                %standard-phases)

What does it do if it doesn’t build anything?  :-)
That seems wrong to me.

> +    (synopsis "GNU MIG, the Mach interface generator")
> +    (description
> +     "GNU MIG is the GNU distribution of the Mach 3.0 interface generator MIG, as maintained by the GNU Hurd developers for the GNU project.
> +You need this tool to compile the GNU Mach and GNU Hurd distributions, and to compile the GNU C library for the Hurd. Also, you will need it
> +for other software in the GNU system that uses Mach-based inter-process communication.")

Please wrap lines to ~75 characters.

Also, for GNU software, we use the “official” synopsis and description.
You can run ‘make sync-descriptions’ to obtain the right for MiG.

Thanks,
Ludo’.

0001_gnu_add_gnumig.patch
Description: Text Data