guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: Add miniupnpc.


From: Andreas Enge
Subject: Re: [PATCH] gnu: Add miniupnpc.
Date: Sun, 23 Feb 2014 10:43:24 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

Hello,

your message headers contain:
  Content-Type: text/plain; charset=y
so that "git am" complains about
  fatal: cannot convert from y to UTF-8
Or does the list software mess it up?

On Sat, Feb 22, 2014 at 10:37:05AM +0100, Sree Harsha Totakura wrote:
> +       #:phases
> +       (alist-delete 
> +          'configure
> +          %standard-phases)))

There is a tiny problem with indentation here.

> +    (license 
> +     (x11-style
> +      
> "https://github.com/miniupnp/miniupnp/blob/master/miniupnpc/LICENSE";))))

Can you refer to a file in the tarball and add the obigatory comment?
Something like:
    (license (x11-style "file://doc/README"
                        "See 'doc/README' in the distribution."))))
(copy-pasted from w3m).

Thanks,

Andreas




reply via email to

[Prev in Thread] Current Thread [Next in Thread]