guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: Add miniupnpc.


From: Sree Harsha Totakura
Subject: Re: [PATCH] gnu: Add miniupnpc.
Date: Mon, 24 Feb 2014 18:49:15 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131103 Icedove/17.0.10

On 02/23/2014 10:43 AM, Andreas Enge wrote:
> your message headers contain:
>   Content-Type: text/plain; charset=y
> so that "git am" complains about
>   fatal: cannot convert from y to UTF-8
> Or does the list software mess it up?

Ah, I think I answered with a 'y' when git complained that it is going
to send the message as UTF-8.  I guess I didn't read the message
properly; I guess it had asked me that character encoding the patch is in.

> 
> On Sat, Feb 22, 2014 at 10:37:05AM +0100, Sree Harsha Totakura wrote:
>> > +       #:phases
>> > +       (alist-delete 
>> > +          'configure
>> > +          %standard-phases)))
> There is a tiny problem with indentation here.
> 
>> > +    (license 
>> > +     (x11-style
>> > +      
>> > "https://github.com/miniupnp/miniupnp/blob/master/miniupnpc/LICENSE";))))
> Can you refer to a file in the tarball and add the obigatory comment?
> Something like:
>     (license (x11-style "file://doc/README"
>                         "See 'doc/README' in the distribution."))))
> (copy-pasted from w3m).

I fixed these in the following patch.

Sree



reply via email to

[Prev in Thread] Current Thread [Next in Thread]