guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Patches for midnight commander


From: Ludovic Courtès
Subject: Re: Patches for midnight commander
Date: Tue, 25 Mar 2014 23:41:28 +0100
User-agent: Gnus/5.130007 (Ma Gnus v0.7) Emacs/24.3 (gnu/linux)

Eric Bavier <address@hidden> skribis:

> The two patches below are for midnight commander.  
>
> The source needs to be fetched from ftp.midnight-commander.org because
> the tarballs on the GNU mirrors have not been updated for a few years...

Heh, OK.

> --- a/gnu/packages/ssh.scm
> +++ b/gnu/packages/ssh.scm
> @@ -110,6 +110,18 @@ remote applications.")
>     (build-system gnu-build-system)
>     (inputs `(("libgcrypt" ,libgcrypt)
>               ("zlib" ,zlib)))
> +   (arguments
> +    '(#:configure-flags
> +      `("--with-libgcrypt"
> +        ;; Programs that use libssh2.pc to link against libssh2 need to also
> +        ;; know where to find libgrypt and zlib libraries.  LDFLAGS are put
> +        ;; into the LIBS field of libssh2.pc
> +        ,(string-append
> +          "LDFLAGS=-L"
> +          (assoc-ref %build-inputs "libgcrypt")
> +          "/lib -L"
> +          (assoc-ref %build-inputs "zlib")
> +          "/lib"))))

Another way to address that would be to rename ‘inputs’ to
‘native-inputs’.  This is more concise and quite common, so I’d prefer
that.  Could you make this change, and keep the comment?

OK to push after that.

> From b16a10d914a52ea685a6ff0326f4b4e35c7d2df4 Mon Sep 17 00:00:00 2001
> From: Eric Bavier <address@hidden>
> Date: Tue, 25 Mar 2014 15:57:28 -0500
> Subject: [PATCH 2/2] gnu: Add mc
>
> * gnu/packages/mc.scm: New file
> * gnu/packages/patches/mc-fix-ncurses-build.patch: New patch
> * gnu-system.am (GNU_SYSTEM_MODULES): Add mc.scm.
> (dist_patch_DATA): Add patch

OK to push!

Thanks,
Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]