[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: Make gtk-glext depend on pangox-compat and remove worka
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH] gnu: Make gtk-glext depend on pangox-compat and remove workaround patch |
Date: |
Wed, 28 May 2014 15:20:12 +0200 |
User-agent: |
Gnus/5.130009 (Ma Gnus v0.9) Emacs/24.3 (gnu/linux) |
John Darrington <address@hidden> skribis:
> On Wed, May 28, 2014 at 01:12:59PM +0200, John Darrington wrote:
> On Wed, May 28, 2014 at 11:57:28AM +0200, Ludovic Court??s wrote:
> Hi John,
>
> Could you make it two separate patches? Why is the patch no longer
> needed?
>
> The patch is no longer needed because of the new dependency. I guess I
> could
> make it two changes, but in my opinion, they belong together.
>
> BTW. Both of your questions are a good example of why I believe the *reason*
> for a change is far more useful in a commit message, than the details
> of what has changed (which is redundant anyway, since it could be seen by
> running "git diff").
In this case, it makes sense to mention in the commit log the reason for
the change.
As for the general case, we’ll stick to
<http://www.gnu.org/prep/standards/html_node/Change-Logs.html>. The
rationale still holds.
Ludo’.