Re: [PATCH] gnu: Add busybox.

[Ludovic Courtès]

Overall looks good to me.  Minor improvements suggested below.

John Darrington <address@hidden> skribis:

>     * gnu/packages/busybox.scm: New file
>     * gnu-system.am: Add gnu/packages/busybox.scm

No indentation needed.

Phrases/sentences started with a capital letter must end with a period.

> +         (lambda _
> +           (begin

No need for ‘begin’ here.

> +             ;; There is no /usr/bin - replace it with /gnu/store
> +             (substitute* "testsuite/cpio.tests"
> +               (("/usr/bin") "/gnu/store"))
> +
> +             (substitute* "testsuite/cpio.tests"
> +               (("usr") "gnu"))

Both clauses can go in a single ‘substitute*’.

> +             ;; This test cannot possibly pass
> +             ;; It is trying to test that "which ls" returns "/bin/ls" when 
> PATH is not set.
> +             ;; However, this relies on /bin/ls existing.  Which it does not 
> in guix

Periods & capitalization.

> +    (native-inputs `(("perl" ,perl) ; Needed to generate the man pages 
> (pod2man)

Lower-case.

> +                     ;; The following are needed by the tests

Period.

Thanks!

Ludo’.