Re: [PATCH] gnu: Add cmatrix.

[Cyrill Schenkel]

Hi

address@hidden (Ludovic Courtès) writes:

> Also, what about putting it in games.scm instead?

Done.

>> +    (build-system gnu-build-system)
>> +    (arguments
>> +     '(#:phases
>> +       (alist-cons-before
>> +        'patch-source-shebangs 'autoreconf
>> +        (lambda args
>> +          (system* "autoreconf" "-fi"))
>> +        %standard-phases)))
>
> This shouldn’t be needed because the tarballs includes ./configure,
> Makefile.in, etc.

Actually it is needed because the configure which comes with the tarball
was generated with a very old version of autotools and doesn't support
the passing of variables (like SHELL). 

>> +    (synopsis "CMatrix simulates the display from \"The Matrix\"")
>
> In general the synopsis shouldn’t repeat the package name, so:
>
>   Simulate the display from \"The Matrix\"

Done.

>
> Could you send an updated patch?

An updated patch is attached.

Regards
Cyrill

>From f0da309bfd8187d8d63386bb908c462fa12fc6f9 Mon Sep 17 00:00:00 2001
From: Cyrill Schenkel <address@hidden>
Date: Tue, 1 Jul 2014 13:02:53 +0200
Subject: [PATCH] gnu: Add cmatrix.

* gnu/packages/games.scm (cmatrix): New variable.
---
 gnu/packages/games.scm | 36 +++++++++++++++++++++++++++++++++++-
 1 file changed, 35 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index 8a2b2df..946f56b 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -2,6 +2,7 @@
 ;;; Copyright © 2013 John Darrington <address@hidden>
 ;;; Copyright © 2014 David Thompson <address@hidden>
 ;;; Copyright © 2014 Eric Bavier <address@hidden>
+;;; Copyright © 2014 Cyrill Schenkel <address@hidden>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -23,6 +24,7 @@
   #:use-module (guix packages)
   #:use-module (guix download)
   #:use-module (gnu packages)
+  #:use-module (gnu packages autotools)
   #:use-module (gnu packages boost)
   #:use-module (gnu packages gettext)
   #:use-module (gnu packages gl)
@@ -32,13 +34,15 @@
   #:use-module (gnu packages guile)
   #:use-module (gnu packages libcanberra)
   #:use-module (gnu packages image)
+  #:use-module (gnu packages ncurses)
   #:use-module (gnu packages python)
   #:use-module (gnu packages readline)
   #:use-module (gnu packages xorg)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages sqlite)
   #:use-module (gnu packages sdl)
-  #:use-module (guix build-system gnu))
+  #:use-module (guix build-system gnu)
+  #:use-module (guix build gnu-build-system))
 
 (define-public gnubg
   (package
@@ -228,3 +232,33 @@ into stereotyped or otherwise humorous dialects.  The 
filters are provided as
 a C library, so they can easily be integrated into other programs.")
     (license gpl2+)))
  
+(define-public cmatrix
+  (package
+    (name "cmatrix")
+    (version "1.2a")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "http://www.asty.org/cmatrix/dist/cmatrix-"; version
+                           ".tar.gz"))
+       (sha256
+        (base32
+         "0k06fw2n8nzp1pcdynhajp5prba03gfgsbj91bknyjr5xb5fd9hz"))))
+    (build-system gnu-build-system)
+    (arguments
+     '(#:phases
+       (alist-cons-before
+        'patch-source-shebangs 'autoreconf
+        (lambda args
+          (system* "autoreconf" "-fi"))
+        %standard-phases)))
+    (inputs `(("ncurses" ,ncurses)
+              ("autoconf" ,autoconf)
+              ("automake" ,automake)))
+    (home-page "http://wwww.asty.org/cmatrix";)
+    (synopsis "Simulate the display from \"The Matrix\"")
+    (description "CMatrix simulates the display from \"The Matrix\" and is
+based on the screensaver from the movie's website.  It works with terminal
+settings up to 132x300 and can scroll lines all at the same rate or
+asynchronously and at a user-defined speed.")
+    (license gpl2+)))
-- 
2.0.0