guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: Add cmatrix.


From: Ludovic Courtès
Subject: Re: [PATCH] gnu: Add cmatrix.
Date: Tue, 01 Jul 2014 14:11:09 +0200
User-agent: Gnus/5.130009 (Ma Gnus v0.9) Emacs/24.3 (gnu/linux)

Cyrill Schenkel <address@hidden> skribis:

> address@hidden (Ludovic Courtès) writes:
>
>> Also, what about putting it in games.scm instead?
>
> Done.
>
>>> +    (build-system gnu-build-system)
>>> +    (arguments
>>> +     '(#:phases
>>> +       (alist-cons-before
>>> +        'patch-source-shebangs 'autoreconf
>>> +        (lambda args
>>> +          (system* "autoreconf" "-fi"))
>>> +        %standard-phases)))
>>
>> This shouldn’t be needed because the tarballs includes ./configure,
>> Makefile.in, etc.
>
> Actually it is needed because the configure which comes with the tarball
> was generated with a very old version of autotools and doesn't support
> the passing of variables (like SHELL). 

Ah sorry.  Still, in that case, it’s easier to just override the
‘configure’ phase as done in time.scm:

       (alist-replace 'configure
                      (lambda* (#:key outputs #:allow-other-keys)
                        ;; This old `configure' script doesn't support
                        ;; variables passed as arguments.
                        (let ((out (assoc-ref outputs "out")))
                          (setenv "CONFIG_SHELL" (which "bash"))
                          (zero?
                           (system* "./configure"
                                    (string-append "--prefix=" out)))))
                      %standard-phases)

Could you do that?

Thanks, and sorry for the round trips.

Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]