Re: [PATCH] gnu: aegis: New variable.

[Ludovic Courtès]

Hi,

Please write “gnu: Add Aegis.” in the summary line.  “New variable” is
when referring to the variable itself in the ChangeLog part.

John Darrington <address@hidden> skribis:

> * gnu/packages/version-control.scm (aegis): New variable.
> * gnu/packages/patches/aegis-constness-error.patch: New file.
> * gnu/packages/patches/aegis-perl-tempdir1.patch: New file.
> * gnu/packages/patches/aegis-perl-tempdir2.patch: New file.
> * gnu/packages/patches/aegis-test-fixup-1.patch: New file.
> * gnu/packages/patches/aegis-test-fixup-2.patch: New file.

Could you merge tempdir1 and tempdir2, as well as fixup1 and fixup2?

> +++ b/gnu/packages/patches/aegis-constness-error.patch
> @@ -0,0 +1,12 @@
> +Fixes a fatal constness error with g++ 4.8.2

Period.

> +++ b/gnu/packages/patches/aegis-perl-tempdir1.patch
> @@ -0,0 +1,14 @@
> +This patch removes the hard coded tmp dir (which might not exist on the 
> system)
> +and replaces it using the perl prefered method

Period, “temporary directory”, “Perl”, “preferred”.

> +++ b/gnu/packages/patches/aegis-test-fixup-1.patch
> @@ -0,0 +1,15 @@
> +This test fails because it expects a mimetype "Content-Type: image/gif"

“MIME type”.

> +;; This package can unfortunately work only in -TEST mode, since aegis ;;

“Aegis”.  Extran semicolon.

> +;; requires that it is installed setuid root, which is not currently possible
> +;; in Guix (hopefully in forthcoming versions this will change).

Remove “, which is not...”.  :-)

The package itself cannot install things setuid (nothing can be setuid
in the store), but there can be setuid programs in the system (see
gnu/system.scm.)

> +(define-public aegis
> +  (package
> +    (name "aegis")
> +    (version "4.24")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "mirror://sourceforge/aegis/aegis-" 
> version ".tar.gz"))

Line length.

OK to push with these changes.

Thanks!

Ludo’.